Add HTTPMessangerInterface #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLKRo
reviewed
Dec 5, 2024
chatsky/messengers/http_interface.py
Outdated
Comment on lines
27
to
45
| class Output(BaseModel): | ||
| user_id: str | ||
| response: Message | ||
|
|
||
| @app.post("/chat", response_model=Output) | ||
| async def respond( | ||
| user_id: str, | ||
| user_message: Message, | ||
| ): | ||
| message = Message(text=user_message) | ||
| context = await pipeline_runner(message, user_id) | ||
| return {"user_id": user_id, "response": context.last_response} | ||
|
|
||
| @app.get("/health", response_model=HealthStatus) | ||
| async def health_check(): | ||
| return { | ||
| "status": "ok", | ||
| "uptime": str(time.time() - self.start_time), | ||
| } |
There was a problem hiding this comment.
It's better to define these (Output, respond, health_check) outside of the connect method and add to the app via
app.post("/chat", response_model=Output)(respond)
app.post("/health", response_model=HealthStatus)(respond)
There was a problem hiding this comment.
I'm not sure this's possible, particularly for the respond method as it needs the pipeline_runner unserializable variable. I.e. it's not possible to pass pipeline_runner as a dependency to the endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new interface
HTTPMessangerInterfacewith an endpoint/chatand health-check one/healthChecklist
List here tasks to complete in order to mark this PR as ready for review.
To Consider
.ignorefiles, scripts (such aslint), distribution manifest (if files are added/deleted)